Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic element - bubbles not pointing to right place due to clientHeight = 0 (etc.) #426

Closed
YochevedZ opened this issue Jul 4, 2019 · 7 comments

Comments

@YochevedZ
Copy link

YochevedZ commented Jul 4, 2019

We use shepherd tour in an ionic environment, but for some elements, bubbles positions are incorrect ONLY on mobile devices (Android & iPhone)
As investigated, on mobile the relevant elements clientWidth, clientHeight, offsetWidth and offsetHeight are zero (0) (but elements locations is correct) and this may impact the shepherd function getBoundingClientRect()
Please advise whether its a shepherd bug or should be handled by client side.
60661111-ec00c300-9e61-11e9-8b2e-69bdf02363b3

@RobbieTheWagner
Copy link
Member

@YochevedZ is this running in a mobile browser or as an app? I've never written a mobile app, so it's possible we may need to add some conditional calls to support it. Do you know if there is an alternative to getBoundingClientRect for mobile?

@YochevedZ
Copy link
Author

YochevedZ commented Jul 4, 2019

It runs on both - both on a mobile browser and as an app.
Please note that the issue occurs on mobile browser - but works well on a desktop browser.
I'm also new in mobile app developing so I have no knowledge of an alternative for getBoundingClientRect() function.

@RobbieTheWagner
Copy link
Member

@YochevedZ I'm confused on the mobile browser issue. Things should work in all browsers, whether mobile or not. Which browser specifically is experiencing issues?

@YochevedZ
Copy link
Author

In iPhone - Safari
In Android - Chrome

@RobbieTheWagner
Copy link
Member

@YochevedZ do you have a reproduction I could play with? Our demo app seems to work in mobile Safari. It does have other issues, but the arrows point to the elements.

@RobbieTheWagner
Copy link
Member

@YochevedZ since I cannot reproduce, I am unsure how to fix this. Can you please help us with a reproduction?

@RobbieTheWagner
Copy link
Member

Since I have not heard back, I am closing for now. Please feel free to reopen if you can provide us with a reproduction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants