Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORM deprecation #50

Closed
VincentLanglet opened this issue Oct 18, 2024 · 1 comment · Fixed by #51
Closed

ORM deprecation #50

VincentLanglet opened this issue Oct 18, 2024 · 1 comment · Fixed by #51

Comments

@VincentLanglet
Copy link

VincentLanglet commented Oct 18, 2024 •
edited
Loading

I'm getting

User Deprecated: Your output walker class ShipMonk\Doctrine\Walker\HintDrivenSqlWalker should implement Doctrine\ORM\Query\OutputWalker in order to provide a Doctrine\ORM\Query\Exec\SqlFinalizer. This also means the output walker should not use the query firstResult/maxResult values, which should be read from the query by the SqlFinalizer only. (Query.php:679 called by Query.php:233, https://github.com/doctrine/orm/pull/11188/, package doctrine/orm)

with the latest version of ORM.

Seems related to doctrine/orm#11188

Not sure if we should make the change and drop support of doctrine/orm < 2.20 @janedbal ?
This was referenced Oct 18, 2024
Open
Merged
@janedbal
Copy link
Member

Thank you, fix released in 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@janedbal @VincentLanglet