Depricates old gem name #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 6, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Na...
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
sfroehler
force-pushed
the
sf-depricate-old-name
branch
from
93d52ad
to
b33edcc
Compare
houndci-bot
reviewed
Apr 6, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
malachewhiz
requested changes
Sep 4, 2018
| @@ -11,6 +11,8 @@ class Client | |||
| attr_accessor :bearer_token | |||
|
|
|||
| def initialize(options = {}) | |||
| warn "[DEPRECATION] This gem has been renamed to billwerk and will no longer be supported. " \ | |||
| "Please switch to the bew gem as soon as possible." | |||
| @@ -11,6 +11,9 @@ | |||
|
|
|||
| ### Security | |||
|
|
|||
| ## [0.3.0] - 2018-04-?? | |||
There was a problem hiding this comment.
Reminder: vor dem Merge das korrekte Datum setzen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.