Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in AdaCos layer implementation #2

Open
rose-jinyang opened this issue Apr 21, 2020 · 4 comments
Open

Mistake in AdaCos layer implementation #2

rose-jinyang opened this issue Apr 21, 2020 · 4 comments

Comments

@rose-jinyang
Copy link

Hello
how are you?
Thanks for contributing your project.
I have a question.
u said that the parameters of AdaCos are adjusted automatically.
However, I found that the parameters are fixed in your project.
Could u explain this in detail.
Thanks

@rose-jinyang
Copy link
Author

rose-jinyang commented Apr 21, 2020

Hi
Moreover, I found that AdaCos layer is same as ArcFace layer in your project.
image
image
How can I understand this confusing?

@rose-jinyang rose-jinyang changed the title Confuse for adjusting AdaCos parameters automatically Mistake on AdaCos layer implementation Apr 21, 2020
@rose-jinyang rose-jinyang changed the title Mistake on AdaCos layer implementation Mistake in AdaCos layer implementation Apr 21, 2020
@shinmura0
Copy link
Owner

AdaCos is a special case of ArcFace.
So, code is same.

Difference is giving parameter.

無題

Paper is below.
https://arxiv.org/abs/1905.00292

And AdaCos is two case.

  • Fixed scale parameter ((12) in paper)
  • Dynamically adaptive scale parameter((14) in paper)

I implemented fixed scale parameter.

@rose-jinyang
Copy link
Author

Thanks for your reply.
Could u implement dynamic scale parameter?
Thanks

@shinmura0
Copy link
Owner

Unfortunately, I cannot implement dynamic scale parameter.
But Fixed AdaCosa is equal to or better than ArcFace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants