whitehair0330 - Incorrect calculation of the lossFee in the GasProcess.processExecutionFee() function.

[sherlock-admin2]

whitehair0330

Medium

Incorrect calculation of the lossFee in the GasProcess.processExecutionFee() function.

Summary

In the processExecutionFee() function, the lossFee is always miscalculated to 0.

Vulnerability Detail

At L24, the lossFee is calculated. However, the executionFee was already adjusted to the same value as userExecutionFee. Consequently, the lossFee is consistently calculated as 0. This leads to the inaccurate modification of the CommonData.

        if (executionFee > cache.userExecutionFee) {
23          executionFee = cache.userExecutionFee;
24          lossFee = executionFee - cache.userExecutionFee;
        } else {

        [...]

39          CommonData.addLossExecutionFee(lossFee);

Impact

The incorrect calculation of the lossFee leads to the improper modification of the CommonData.

Code Snippet

https://github.com/sherlock-audit/2024-05-elfi-protocol/blob/main/elfi-perp-contracts/contracts/process/GasProcess.sol#L17-L41

Tool used

Manual Review

Recommendation

The GasProcess.processExecutionFee() function should be fixed as follows.

-           executionFee = cache.userExecutionFee;
            lossFee = executionFee - cache.userExecutionFee;
+           executionFee = cache.userExecutionFee;

Duplicate of #108