seeques - getPrice() and getOriginalPrice() doesn't check whether arbitrum sequencer is down

[sherlock-admin]

seeques

medium

getPrice() and getOriginalPrice() doesn't check whether arbitrum sequencer is down

Summary

Downtimes are common on L2s so it is important to validate if Arbitrum sequencer is operational before any state-changing operation occurs. This is to ensure that the prices are fresh and not stale.

Vulnerability Detail

D3Oracle.getPrice() and D3Oracle.getOriginalPrice() functions don't check if Arbitrum sequencer is down.

Impact

Stale prices would be used and might result in false liquidations.

Code Snippet

https://github.com/sherlock-audit/2023-06-dodo/blob/main/new-dodo-v3/contracts/DODOV3MM/periphery/D3Oracle.sol#L48
https://github.com/sherlock-audit/2023-06-dodo/blob/main/new-dodo-v3/contracts/DODOV3MM/periphery/D3Oracle.sol#L58

Tool used

Manual Review

Recommendation

Follow the chainlink example code
https://docs.chain.link/data-feeds/l2-sequencer-feeds#example-code

Duplicate of #62