Nyx - Chainlink's latestRoundData might return stale or incorrect results

[sherlock-admin]

Nyx

medium

Chainlink's latestRoundData might return stale or incorrect results

Summary

Chainlink's latestRoundData() is used but there is no check if the return value indicates stale data. This could lead to stale prices according to the Chainlink documentation:

https://docs.chain.link/docs/historical-price-data/#historical-rounds

Vulnerability Detail

functions use Chainlink's latestRoundData() to get the latest price. However, there is no check if the return value indicates stale data.

Impact

Function could return stale price data for the underlying asset.

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/oracles/StableOracleDAI.sol#L33-L54

Tool used

Manual Review

Recommendation

Consider adding checks for stale data.

Duplicate of #31