You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.
sherlock-admin opened this issue
May 24, 2023
· 0 comments
Labels
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelHighA valid High severity issueRewardA payout will be made for this issue
In StableOracles, some addresses are hardcoded but incorrectly addressed.
Vulnerability Detail
There is an oracle for each collateral, each referring to several external addresses. However, the oracles do not work properly because their addresses are incorrect.
Impact
The oracle does not work, and important functions of the protocols that depend on it are not available.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelHighA valid High severity issueRewardA payout will be made for this issue
innertia
high
Hardcoded address error
Summary
In
StableOracles
, some addresses are hardcoded but incorrectly addressed.Vulnerability Detail
There is an oracle for each collateral, each referring to several external addresses. However, the oracles do not work properly because their addresses are incorrect.
Impact
The oracle does not work, and important functions of the protocols that depend on it are not available.
Code Snippet
https://github.com/sherlock-audit/2023-05-USSD/blob/6d7a9fdfb1f1ed838632c25b6e1b01748d0bafda/ussd-contracts/contracts/oracles/StableOracleDAI.sol#L27-L28
https://github.com/sherlock-audit/2023-05-USSD/blob/6d7a9fdfb1f1ed838632c25b6e1b01748d0bafda/ussd-contracts/contracts/oracles/StableOracleDAI.sol#L30
https://github.com/sherlock-audit/2023-05-USSD/blob/6d7a9fdfb1f1ed838632c25b6e1b01748d0bafda/ussd-contracts/contracts/oracles/StableOracleWBGL.sol#L19
https://github.com/sherlock-audit/2023-05-USSD/blob/6d7a9fdfb1f1ed838632c25b6e1b01748d0bafda/ussd-contracts/contracts/oracles/StableOracleWBTC.sol#L17
Tool used
Manual Review
Recommendation
Replace with exact address
Duplicate of #817
The text was updated successfully, but these errors were encountered: