Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

kiki_dev - Missing working address for ethOracle #77

Closed
sherlock-admin opened this issue May 23, 2023 · 0 comments
Closed

kiki_dev - Missing working address for ethOracle #77

sherlock-admin opened this issue May 23, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 23, 2023

kiki_dev

medium

Missing working address for ethOracle

Summary

In StableOracleDAI.sol the variable ethOracle is supposed to be set inside the constructor. However no real value is ever set.

Vulnerability Detail

Currently the constructor has this:
ethOracle = IStableOracle(0x0000000000000000000000000000000000000000); // TODO: WETH oracle price
with the incomplete constructor the protocol will not work because ethOracle will fail in its current state.

Impact

Protocol will not work

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/oracles/StableOracleDAI.sol#L30

Tool used

Manual Review

Recommendation

Finish setting a valid address for ethOracle by finishing the TODO that was already in place.

Duplicate of #817

@github-actions github-actions bot closed this as completed Jun 5, 2023
@github-actions github-actions bot added High A valid High severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 5, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant