You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.
sherlock-admin opened this issue
May 23, 2023
· 0 comments
Labels
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelHighA valid High severity issueRewardA payout will be made for this issue
In StableOracleDAI.sol the variable ethOracle is supposed to be set inside the constructor. However no real value is ever set.
Vulnerability Detail
Currently the constructor has this: ethOracle = IStableOracle(0x0000000000000000000000000000000000000000); // TODO: WETH oracle price
with the incomplete constructor the protocol will not work because ethOracle will fail in its current state.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
DuplicateA valid issue that is a duplicate of an issue with `Has Duplicates` labelHighA valid High severity issueRewardA payout will be made for this issue
kiki_dev
medium
Missing working address for ethOracle
Summary
In
StableOracleDAI.sol
the variableethOracle
is supposed to be set inside the constructor. However no real value is ever set.Vulnerability Detail
Currently the constructor has this:
ethOracle = IStableOracle(0x0000000000000000000000000000000000000000); // TODO: WETH oracle price
with the incomplete constructor the protocol will not work because ethOracle will fail in its current state.
Impact
Protocol will not work
Code Snippet
https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/oracles/StableOracleDAI.sol#L30
Tool used
Manual Review
Recommendation
Finish setting a valid address for
ethOracle
by finishing the TODO that was already in place.Duplicate of #817
The text was updated successfully, but these errors were encountered: