Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

sashik_eth - Missing redeem function #768

Closed
sherlock-admin opened this issue May 24, 2023 · 0 comments
Closed

sashik_eth - Missing redeem function #768

sherlock-admin opened this issue May 24, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 24, 2023

sashik_eth

high

Missing redeem function

Summary

Missing redeem function.

Vulnerability Detail

Users can mint new USSD tokens by providing the appropriate amount of collateral tokens. However, the protocol missing functionality to withdraw collateral (redeem USSD tokens).

Impact

Users would be unable to redeem minted USSD tokens back to collateral. This would result in collateral stuck on the USSD balance or forcing users to "redeem" through selling in USSD on AMM which would lead to losses compared with regular redeeming flow.

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/USSD.sol#L147

Tool used

Manual Review

Recommendation

Consider implementing redeem function that would allow users to withdraw collateral from USSD.

Duplicate of #958

@github-actions github-actions bot closed this as completed Jun 5, 2023
@github-actions github-actions bot added High A valid High severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 5, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 23, 2023
@sherlock-admin2 sherlock-admin2 added Medium A valid Medium severity issue and removed High A valid High severity issue labels Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

2 participants