Proxy - Oracle will return too expensive price of DAI because of excessive precision scaling

[sherlock-admin]

Proxy

high

Oracle will return too expensive price of DAI because of excessive precision scaling

Summary

Oracle will return too expensive price because of excessive precision scaling.

Vulnerability Detail

In StableOracleDAI.sol#L52 price is being multiplied by 1e10 -> uint256(price) * 1e10 assuming that Chainlink price feed returns 8 decimals. However checking the decimals of the oracle address used DAI/ETH decimals we see that it returns 18 decimals.

Impact

The price of DAI will not be representative of the real price of DAI - too expensive. Causing the protocol to pay way more for collateral while rebalancing. rebalance() calls two functions which use getPriceUSD() from StableOracleDAI contract.

Code Snippet

StableOracleDAI.sol#L52

Tool used

Manual Review

Recommendation

Change uint256(price) * 1e10 to uint256(price) removing * 1e10

Duplicate of #236