Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

ravikiran.web3 - Chainlink address for StableOracleWBTC is wrong #17

Closed
sherlock-admin opened this issue May 23, 2023 · 0 comments
Closed

ravikiran.web3 - Chainlink address for StableOracleWBTC is wrong #17

sherlock-admin opened this issue May 23, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 23, 2023 •
edited by github-actions bot
Loading

ravikiran.web3

high

Chainlink address for StableOracleWBTC is wrong

Summary

The chainlink address for StableOracleWBTC is wrong. It is pointing to WETH instead. Looks like a copy paste error.

Vulnerability Detail

configured a wrong address for the chainlink AggregatorV3Interface.

Impact

The oracle will return totally wrong prices causing an incorrect calculation of collateral. This will directly impact the rebalance logic of the USSDRebalancer contract.

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/oracles/StableOracleWBTC.sol#L16-L19

Tool used

Manual Review

Recommendation

Update the address passed to the chainlink AggregatorV3Interface as below.
0xf4030086522a5beea4988f8ca5b36dbc97bee88c
With this update, the oracle will return BTC/USD prices instead of ETH/USD prices

Duplicate of #817
@github-actions github-actions bot closed this as completed Jun 5, 2023
@github-actions github-actions bot added High A valid High severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 5, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sherlock-admin