Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

Fanz - StableOracleWETH has no check for round completeness #10

Closed
sherlock-admin opened this issue May 23, 2023 · 0 comments
Closed

Fanz - StableOracleWETH has no check for round completeness #10

sherlock-admin opened this issue May 23, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 23, 2023

Fanz

medium

StableOracleWETH has no check for round completeness

Summary

StableOracleWETH has no check for round completeness

Vulnerability Detail

StableOracleWETH has no check for round completeness

Impact

latestRoundData() might return stale results.

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/oracles/StableOracleWETH.sol#L23

Tool used

Manual Review

Recommendation

Summary
StableOracleWBTC has no check for round completeness

Vulnerability Detail
StableOracleWBTC has no check for round completeness

Impact
latestRoundData() might return stale results.

Code Snippet
https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/oracles/StableOracleWBTC.sol#L23

Tool used
Manual Review

Recommendation
Add roundId check

Duplicate of #31

@github-actions github-actions bot closed this as completed Jun 5, 2023
@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 5, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant