Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

rvierdiiev - DepositManagerV1.fundBountyNFT doesn't check if address limit is reached #104

Closed
github-actions bot opened this issue Feb 21, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@github-actions
Copy link

github-actions bot commented Feb 21, 2023

rvierdiiev

medium

DepositManagerV1.fundBountyNFT doesn't check if address limit is reached

Summary

DepositManagerV1.fundBountyNFT doesn't check if address limit is reached

Vulnerability Detail

When user wants to make deposit into bounty through DepositManagerV1.fundBountyToken, then openQTokenWhitelist is checking if token is allowed to use and also if openQTokenWhitelist has reached limit of allowed tokens.
In case if more tokens than limit is added into openQTokenWhitelist contract, then all deposits should be disallowed.

But user still can deposit using DepositManagerV1.fundBountyNFT function in case if limit is reached, as it checks only if token is allowed.
As result that restriction is not working and user is still able to deposit nft into bounty contract.

Impact

Code Snippet

https://github.com/sherlock-audit/2023-02-openq/blob/main/contracts/DepositManager/Implementations/DepositManagerV1.sol#L113-L147

Tool used

Manual Review

Recommendation

Add same check as in fundBountyToken function.

Duplicate of #530

@github-actions github-actions bot added Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue labels Feb 21, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant