Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for incorrect types path in package.json #434

Merged
merged 1 commit into from
Jul 14, 2019
Merged

fix for incorrect types path in package.json #434

merged 1 commit into from
Jul 14, 2019

Conversation

cmcnicholas
Copy link
Contributor

@cmcnicholas cmcnicholas commented Jul 14, 2019

incorrect path to types file results in no intellisense or typing support

Fixes #435

incorrect path to types file results in no intellisense or typing support
@RobbieTheWagner
Copy link
Member

Thanks so much @cmcnicholas! Are you using Shepherd with Typescript? If so, how has it been going? I haven't used TS myself, so I was curious how the typings were working and if there was anything we needed to tweak?

@RobbieTheWagner RobbieTheWagner merged commit 8b180de into shipshapecode:master Jul 14, 2019
@cmcnicholas
Copy link
Contributor Author

I have just started using Shepherd so need to really dig in to it, I've been using typescript for about 18 months now so have a fair amount of experience. I'm enjoying it so far, typings seem mostly correct so far, some are a little vague e.g. string when there is an accepted enumeration but otherwise all well. Will test more and report back though.

@RobbieTheWagner
Copy link
Member

@cmcnicholas thanks! If you find things that are wrong or could be improved, please let us know! Outside of Typescript as well, if you see any weird issues with the lib in general, please bring them to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect path to typings files in package.json
2 participants