shift + tab handled #1119
Merged
shift + tab handled #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
requested changes
Aug 28, 2020
| @@ -79,7 +79,7 @@ | |||
| } | |||
| // Backward tab | |||
| if (e.shiftKey) { | |||
| if (document.activeElement === firstFocusableElement) { | |||
| if (document.activeElement === firstFocusableElement || document.activeElement.hasAttribute("data-popper-placement")) { | |||
There was a problem hiding this comment.
Would it perhaps make more sense to check for a class of shepherd-element?
There was a problem hiding this comment.
That would be perfect! Thanks for the suggestion
RobbieTheWagner
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #1076 by adding an additional check on
data-popper-placementattribute ondocument.activeElementwhenshiftKeyis pressed