Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After tour is canceled/completed and started again, overlay is not present anymore #347

Closed
michalius opened this issue Mar 22, 2019 · 5 comments · Fixed by #358
Closed

After tour is canceled/completed and started again, overlay is not present anymore #347

michalius opened this issue Mar 22, 2019 · 5 comments · Fixed by #358
Labels
bug

Comments

@michalius
Copy link

Works fine when using hide() and show(), but seems overlay is destroyed after cancel() or complete().
@Prabashi
Copy link

The opposite happened to me; when I used hide() as an action for a button, in the tour when the button is clicked, in the next time of the tour, the overlay is destroyed (applied even to the specified element that is targeted by the step). On the other hand, when cancel() or complete() is used, it worked fine.

@RobbieTheWagner
Copy link
Member

There is definitely something odd going on here. Would either of you be interested in helping debug? I will try to take a look soon.

@Prabashi
Copy link

Prabashi commented Apr 6, 2019

I would like to help in the debug and fixing this issue.

@RobbieTheWagner
Copy link
Member

That would be great @Prabashi! Let me know if you have questions.

@jayjfletcher jayjfletcher mentioned this issue Apr 18, 2019
Merged
@jayjfletcher
Copy link
Contributor

A PR was submitted for this issue

RobbieTheWagner added a commit that referenced this issue Apr 22, 2019
@RobbieTheWagner
Add createModalOverlay function
910db0e 
Fixes #347
@RobbieTheWagner RobbieTheWagner mentioned this issue Apr 22, 2019
Merged
RobbieTheWagner added a commit that referenced this issue Apr 22, 2019
@RobbieTheWagner
Add createModalOverlay function (#358)
5ec4c04 
Fixes #347
@appleneil appleneil mentioned this issue Mar 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add createModalOverlay function shipshapecode/shepherd
4 participants
@RobbieTheWagner @jayjfletcher @Prabashi @michalius