buildpack_spec.rb

require_relative "../spec_helper.rb"

RSpec.describe "This buildpack" do
  it "accepts absolute paths at build and runtime" do
    app_dir = generate_fixture_app(
      name: "works",
      compile_script: <<~EOM
        #!/usr/bin/env bash


        # Test export
        echo "export PATH=/good/absolute/path:$PATH" >> export

        # Test .profile.d
        BUILD_DIR=$1
        mkdir -p $BUILD_DIR/.profile.d

        echo "export PATH=/good/absolute/path:$PATH" >> $BUILD_DIR/.profile.d/my.sh
      EOM
    )

    buildpacks = [
      "https://github.com/heroku/heroku-buildpack-inline",
      :default
    ]

    Hatchet::Runner.new(app_dir, buildpacks: buildpacks).deploy do |app|
      expect(app.output).to_not include("All paths must be absolute")
    end
  end

  describe "export detection" do
    it "errors on relative paths" do
      app_dir = generate_fixture_app(
        name: "export_fails_relative",
        compile_script: <<~EOM
          #!/usr/bin/env bash

          echo "export PATH=bad_export_path_because_im_relative:$PATH" >> export
        EOM
      )

      buildpacks = [
        "https://github.com/heroku/heroku-buildpack-inline",
        :default
      ]

      Hatchet::Runner.new(app_dir, buildpacks: buildpacks, allow_failure: true).deploy do |app|
        expect(app.output).to include("All paths must be absolute")
      end
    end
  end

  describe "profile.d detection" do
    it "errors on relative paths" do
      app_dir = generate_fixture_app(
        name: "export_fails_relative",
        compile_script: <<~EOM
          #!/usr/bin/env bash

          BUILD_DIR=$1
          mkdir -p $BUILD_DIR/.profile.d

          echo "export PATH=bad_export_path_because_im_relative:$PATH" >> $BUILD_DIR/.profile.d/my.sh
        EOM
      )

      buildpacks = [
        "https://github.com/heroku/heroku-buildpack-inline",
        :default
      ]

      Hatchet::Runner.new(app_dir, buildpacks: buildpacks, allow_failure: true).deploy do |app|
        expect(app.output).to include("All paths must be absolute")
      end
    end
  end

  describe "leaky build path detection" do
    it "errors on leaky paths" do
      app_dir = generate_fixture_app(
        name: "leaky_build_path",
        compile_script: <<~EOM
          #!/usr/bin/env bash

          BUILD_DIR=$1
          mkdir -p $BUILD_DIR/.profile.d

          echo "export PATH=$BUILD_DIR/foo:$PATH" >> $BUILD_DIR/.profile.d/my.sh
        EOM
      )

      buildpacks = [
        "https://github.com/heroku/heroku-buildpack-inline",
        :default
      ]

      Hatchet::Runner.new(app_dir, buildpacks: buildpacks, allow_failure: true).deploy do |app|
        expect(app.output).to include("A build path leaked into runtime")
      end
    end
  end

  describe "ignoring keys" do
    it "doesn't raise at build" do
      app_dir = generate_fixture_app(
        name: "ignore_path_build",
        compile_script: <<~EOM
          #!/usr/bin/env bash

          echo "export IGNORE_THIS_PATH=bad_export_path_because_im_relative" >> export
        EOM
      )

      buildpacks = [
        "https://github.com/heroku/heroku-buildpack-inline",
        :default
      ]

      Hatchet::Runner.new(app_dir, buildpacks: buildpacks, config: { FORCE_ABSOLUTE_PATHS_BUILDPACK_IGNORE_PATHS: "IGNORE_THIS_PATH"}).deploy do |app|
        expect(app.output).to include("Ignoring key IGNORE_THIS_PATH")
      end
    end

    it "doesn't raise at runtime" do
      app_dir = generate_fixture_app(
        name: "ignore_path_runtime",
        compile_script: <<~EOM
          #!/usr/bin/env bash

          BUILD_DIR=$1
          mkdir -p $BUILD_DIR/.profile.d

          echo "export IGNORE_THIS_PATH=bad_path_because_relativ" >> $BUILD_DIR/.profile.d/my.sh
        EOM
      )

      buildpacks = [
        "https://github.com/heroku/heroku-buildpack-inline",
        :default
      ]

      Hatchet::Runner.new(app_dir, buildpacks: buildpacks, allow_failure: true, config: { FORCE_ABSOLUTE_PATHS_BUILDPACK_IGNORE_PATHS: "IGNORE_THIS_PATH"}).deploy do |app|
        expect(app.output).to include("Ignoring key IGNORE_THIS_PATH")
      end
    end
  end
end