Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the NO_COLOR environment variable #179

Closed
mjf opened this issue Nov 29, 2022 · 4 comments · Fixed by #183 or #210
Closed

Add support for the NO_COLOR environment variable #179

mjf opened this issue Nov 29, 2022 · 4 comments · Fixed by #183 or #210
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mjf
Copy link

mjf commented Nov 29, 2022 •
edited
Loading

Please, add support for the NO_COLOR environment variable, if possible.
@sharkdp
Copy link
Owner

sharkdp commented Dec 4, 2022

Sure, sounds reasonable.

@sharkdp sharkdp added enhancement New feature or request good first issue Good for newcomers labels Dec 4, 2022
@mainrs
Copy link

mainrs commented Dec 6, 2022

This can be done by using another dependency for colored text instead of the current one.
owo-colors supports the env variable natively and has zero overhead printing colored text.

I can work on this issue if that's ok.

@sharifhsn sharifhsn mentioned this issue Dec 6, 2022
Merged
@nagy
Copy link

nagy commented Oct 30, 2023

Is it possible, that this has not really been fixed? When I run NO_COLOR=1 hexyl <<< hi I still see colored output. Am I doing something wrong? That is on hexyl version 0.13.1.

@sharkdp sharkdp reopened this Nov 1, 2023
@sharkdp
Copy link
Owner

sharkdp commented Nov 1, 2023

Strange. Doesn't work for me either. Re-opening for now.

@sharkdp sharkdp mentioned this issue Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use owo-colors instead of anstyle sharifhsn/hexyl
Fix NO_COLOR behavior sharkdp/hexyl
4 participants
@mjf @nagy @sharkdp @mainrs