SHARD-1113 #93
Merged
SHARD-1113 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketdivekar
previously approved these changes
Dec 6, 2024
|
Addressed comment, pinged Abdul to review again |
abdulazeem-tk4vr
previously approved these changes
Dec 6, 2024
|
I see some changes were made to the package-lock as well. They were not in the scope of this task. I want to make sure that those changes are fine. |
kun6fup4nd4
previously approved these changes
Dec 11, 2024
mssabr01
dismissed stale reviews from kun6fup4nd4 and abdulazeem-tk4vr
via
e332dfb
kun6fup4nd4
approved these changes
Dec 11, 2024
abdulazeem-tk4vr
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added size limits to the number of wallet addresses and number of filters allowed in eth_newFilter to prevent OOM and DOS-level performance slowdowns