Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source maps #3

Open
conradz opened this issue Dec 24, 2014 · 3 comments
Open

Source maps #3

conradz opened this issue Dec 24, 2014 · 3 comments

Comments

@conradz
Copy link

conradz commented Dec 24, 2014

As far as I can tell, there is currently no way to generate source maps when using this. It would be great if this would support source maps with an API similar to escodegen's.

@michaelficarra
Copy link
Member

This will depend on shapesecurity/shift-spec#7 being accepted. Otherwise, we'd have to figure out some other way to specify source locations.

@michaelficarra
Copy link
Member

This is now blocked by #2.

@bakkot
Copy link
Member

bakkot commented Oct 14, 2016

I don't think this is blocked by anything now. Given the current API to parseScriptWithLocation, the interface should presumably be a third, optional parameter (or another entry point) taking a [Weak]Map from nodes to locations.

Edit: Or possibly (Map, file name) pairs, given that source maps can map multiple input files to one output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants