Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Demo and Simple React are broken #207

Closed
justin808 opened this issue Jan 24, 2016 · 3 comments
Closed

React Demo and Simple React are broken #207

justin808 opened this issue Jan 24, 2016 · 3 comments
Labels

Comments

@justin808
Copy link
Member

2016-01-23_19-40-31

React Demo and Simple React links are broken and CI passes. Nothing is rendered for those links in production.

CC: @robwise @geoffevason @yorzi @MaMute @josiasds

If anybody can take a look at this, I'd super appreciate it.

This is reproducible both on heroku and locally.

There are no console errors.

It might be related to turbolinks and the way we render react components when we get a page loaded event.

@justin808 justin808 added the bug label Jan 24, 2016
@justin808
Copy link
Member Author

shakacode/react_on_rails#221 fixes the issue.

@marcusvmsa
Copy link
Contributor

@justin808 I've tested locally and your fix is working great, but there is another bug. No comment is been added since the CSRF token sent in the headers is incorrect. This was fixed id #209

@justin808
Copy link
Member Author

Fixed a while back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants