Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Timeout unfulfilled request to decodingInfo and requestMediaKeySystemAccess #7682

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

CHaNGeTe
Copy link
Contributor

On some (Android) WebView environments,
decodingInfo and requestMediaKeySystemAccess will
not resolve or reject, at least if RESOURCE_PROTECTED_MEDIA_ID is not set.
This is a workaround for that issue.

Closes #7680

…ystemAccess

On some (Android) WebView environments,
decodingInfo and requestMediaKeySystemAccess will
not resolve or reject, at least if RESOURCE_PROTECTED_MEDIA_ID
is not set.  This is a workaround for that issue.
Copy link

google-cla bot commented Nov 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@avelad avelad requested a review from joeyparrish November 27, 2024 12:40
@avelad avelad added the type: bug Something isn't working correctly label Nov 27, 2024
@CHaNGeTe
Copy link
Contributor Author

I will need help with the failing tests

lib/media/drm_engine.js Outdated Show resolved Hide resolved
@CHaNGeTe CHaNGeTe requested a review from tykus160 November 27, 2024 14:19
@tykus160
Copy link
Member

@CHaNGeTe could you sign CLA? Check #7682 (comment)

@CHaNGeTe
Copy link
Contributor Author

@CHaNGeTe could you sign CLA? Check #7682 (comment)

I am working on it, asked the company for sign it

@tykus160
Copy link
Member

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@tykus160: Lab tests started with arguments:

  • pr=7682

lib/media/drm_engine.js Show resolved Hide resolved
lib/util/functional.js Show resolved Hide resolved
@tykus160
Copy link
Member

@shaka-bot test ce

@shaka-bot
Copy link
Collaborator

@tykus160: Lab tests started with arguments:

  • pr=7682
  • browser_filter=Tizen ChromecastUltra ChromecastGTV ChromeAndroid

@CHaNGeTe CHaNGeTe requested a review from tykus160 November 29, 2024 08:33
@avelad avelad added this to the v4.13 milestone Nov 29, 2024
@avelad avelad added priority: P2 Smaller impact or easy workaround platform: Android Issues affecting Android labels Nov 29, 2024
@avelad avelad merged commit 07894ec into shaka-project:main Nov 29, 2024
24 of 25 checks passed
avelad pushed a commit that referenced this pull request Dec 4, 2024
…ystemAccess (#7682)

On some (Android) WebView environments,
decodingInfo and requestMediaKeySystemAccess will
not resolve or reject, at least if RESOURCE_PROTECTED_MEDIA_ID is not
set.
This is a workaround for that issue.

Closes #7680
avelad pushed a commit that referenced this pull request Dec 4, 2024
…ystemAccess (#7682)

On some (Android) WebView environments,
decodingInfo and requestMediaKeySystemAccess will
not resolve or reject, at least if RESOURCE_PROTECTED_MEDIA_ID is not
set.
This is a workaround for that issue.

Closes #7680
joeyparrish pushed a commit that referenced this pull request Dec 11, 2024
…ystemAccess (#7682)

On some (Android) WebView environments,
decodingInfo and requestMediaKeySystemAccess will
not resolve or reject, at least if RESOURCE_PROTECTED_MEDIA_ID is not
set.
This is a workaround for that issue.

Closes #7680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android Issues affecting Android priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
4 participants