Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow the user to disable subtitles while paused #7578

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 13, 2024

Fixes #7576

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Nov 13, 2024
@avelad avelad added this to the v4.13 milestone Nov 13, 2024
@joeyparrish joeyparrish changed the title fix: Disable subtitles while paused fix: Allow the user to disable subtitles while paused Nov 13, 2024
@avelad avelad merged commit f41c65d into shaka-project:main Nov 13, 2024
24 checks passed
@avelad avelad deleted the disable-subtitles-paused branch November 13, 2024 16:56
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 12, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabling subtitles whilst paused, they remain on screen
4 participants