Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Seek delay for Cast Nest hub #7423

Merged
merged 7 commits into from
Oct 18, 2024
Merged

fix: Seek delay for Cast Nest hub #7423

merged 7 commits into from
Oct 18, 2024

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Oct 14, 2024 •
edited
Loading

Fuchsia devices need more time to seek. 1 second is not enough and 3 look a correct value
related to this #7424

Iragne added 2 commits October 14, 2024 15:33
@Iragne
Add the seek delay for Chrome cast configurable
ae21409 
Fuchsia devices where 3 is a correct value
@Iragne
Nest Hub
2e694f3
@Iragne
Copy link
Contributor Author

Iragne commented Oct 14, 2024

FYI We are running it now in prod

@shaka-bot
Copy link
Collaborator

shaka-bot commented Oct 14, 2024 •
edited
Loading

Incremental code coverage: 0.00%

tykus160
tykus160 reviewed Oct 15, 2024
View reviewed changes
externs/shaka/player.js Outdated
Comment on lines 1635 to 1636
* The minimum time duration (in seconds) before we can operate a new seek
* on cast devices (Only for Chromecast)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's for devices which have slow seek time. Even now, it does not apply to Android based Chromecasts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the text let me know if you agree ? @tykus160

avelad
avelad requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@avelad avelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is a known issue and only happens on that device, I think there should be no setting. I think we should include that value in the library as is.

@Iragne
Copy link
Contributor Author

Iragne commented Oct 18, 2024

@avelad I'm happy to add it in the configuration automatically when it's a Fushia device and casting.
FYI it's the nest hub the device we are using for testing

@avelad
Copy link
Member

avelad commented Oct 18, 2024

@avelad I'm happy to add it in the configuration automatically when it's a Fushia device and casting. FYI it's the nest hub the device we are using for testing

No no, I want to remove the configuration and hardcode the number in lib/media/playhead.js

@Iragne Iragne changed the title feat: Add the seek delay for Chromecast configurable fix: Seek delay for Cast Nest hub configurable with default configuration Oct 18, 2024
@Iragne
Copy link
Contributor Author

Iragne commented Oct 18, 2024 •
edited
Loading

Oh ok will do

@Iragne Iragne changed the title fix: Seek delay for Cast Nest hub configurable with default configuration fix: Seek delay for Cast Nest hub Oct 18, 2024
avelad
avelad requested changes Oct 18, 2024
View reviewed changes
lib/media/playhead.js Outdated Show resolved Hide resolved
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: Cast Issues affecting Cast devices labels Oct 18, 2024
@avelad avelad added this to the v4.12 milestone Oct 18, 2024
@avelad
Copy link
Member

avelad commented Oct 18, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7423

@avelad avelad merged commit d454514 into shaka-project:main Oct 18, 2024
28 of 32 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 18, 2024
Merged
avelad pushed a commit that referenced this pull request Oct 18, 2024
@Iragne @avelad
fix: Seek delay for Cast Nest hub (#7423)
2997dc0 
Fuchsia devices need more time to seek. 1 second is not enough and 3 look a correct value
related to this
#7424
@shaka-bot shaka-bot mentioned this pull request Oct 18, 2024
Merged
avelad pushed a commit that referenced this pull request Oct 18, 2024
@Iragne @avelad
fix: Seek delay for Cast Nest hub (#7423)
fb3a333 
Fuchsia devices need more time to seek. 1 second is not enough and 3 look a correct value
related to this
#7424
@shaka-bot shaka-bot mentioned this pull request Oct 18, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Oct 18, 2024
@Iragne @joeyparrish
fix: Seek delay for Cast Nest hub (#7423)
465174c 
Fuchsia devices need more time to seek. 1 second is not enough and 3 look a correct value
related to this
#7424
@shaka-bot shaka-bot mentioned this pull request Oct 18, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Dec 11, 2024
@Iragne @joeyparrish
fix: Seek delay for Cast Nest hub (#7423)
3adfd8f 
Fuchsia devices need more time to seek. 1 second is not enough and 3 look a correct value
related to this
#7424
This was referenced Dec 11, 2024
Closed
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 17, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
platform: Cast Issues affecting Cast devices priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.
4 participants
@Iragne @shaka-bot @avelad @tykus160