fix(UI): Restore missing AirPlay button

[tykus160]

No description provided.

[shaka-bot]

Incremental code coverage: 83.33%

[joeyparrish]

@avelad texted me and says this "should work fine with remote": "I implemented remote in the past and it works with AirPlay".

[tykus160]

@joeyparrish the problem is, remote is always in HTMLMediaElement, so this if/else condition causes no AirPlay button in the UI.

[joeyparrish]

I think Alvaro is saying that remote should suffice for AirPlay in the UI. I can't confirm this either way.

[joeyparrish]

You can move forward if you're sure this is right. We trust you. If Alvaro disagrees with this, he can work it out with you when he returns from leave.

[tykus160]

@joeyparrish OK, apparently the issue was with handling of disableRemotePlayback option. Adjusted now, we can use remote button and AirPlay works whenever src= mode is enabled.

[absidue]

@tykus160 I don't see shaka-player setting it to true anywhere, so is this to work around a Safari bug or is your own code setting disableRemotePlayback to true?

[joeyparrish]

My only concern is that we're changing the DOM now. In general, if an app sets disableRemotePlayback to true in the DOM, we shouldn't change that here.

Is the default for disableRemotePlayback true or false?

[tykus160]

Default is false. We're explictly setting it to true when ManagedMediaSource is in use, I saw otherwise there are some problems even with rendering of demo page.

[tykus160]

We might stop setting it explicitly at all, but I think it may raise issues when ManagedMediaSource is used.

[joeyparrish]

OK, sounds good, then.

[tykus160]

@absidue @joeyparrish disableRemotePlayback is set to true when ManagedMediaSource is used.
To make our code less invasive, I'm setting it back to false only in src= scenario, MediaSourceEngine has been created and ManagedMediaSource exists.

[gkatsev]

MMS requires disableRemotePlayback to be false unless a second source is added to the video element with the full hls url for airplay. There was this change related to it, but it wasn't ready to be merged: #7136. So, all of this probably would need to be updated once shaka can add that secondary source.

[tykus160]

@gkatsev I'm aware, but shaka creates MSE before an actual playback and lack of disableRemotePlayback=true causes issues. I'm testing adding secondary source for AirPlay.