fix: Revert change that caused stalls with "cannot find endTime" #7213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witches …" This reverts commit 4cff18d.
avelad
approved these changes
Aug 26, 2024
joeyparrish
deleted the
revert-7157-defer-old-stream-clean-on-abr-switch
branch
|
Incremental code coverage: 100.00% |
joeyparrish
added a commit
that referenced
this pull request
Aug 27, 2024
Reverts #7157 ("fix: Defer `closeSegmentIndex()` for old streams during ABR switches when segment fetches are ongoing") A regression was reported in video-dev.org Slack, and they narrowed it down to this PR. Playing https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/4577dca5f8a44756875ab5cc913cd1f1/index.mpd with this PR, reportedly: > playback stops rendering with a warning "cannot find segment endTime" just a few seconds prior to the rendering alt. This was initially observed on Samsung TVs, but then later on LG and even in Chrome.
joeyparrish
added a commit
that referenced
this pull request
Aug 27, 2024
Reverts #7157 ("fix: Defer `closeSegmentIndex()` for old streams during ABR switches when segment fetches are ongoing") A regression was reported in video-dev.org Slack, and they narrowed it down to this PR. Playing https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/4577dca5f8a44756875ab5cc913cd1f1/index.mpd with this PR, reportedly: > playback stops rendering with a warning "cannot find segment endTime" just a few seconds prior to the rendering alt. This was initially observed on Samsung TVs, but then later on LG and even in Chrome.
JulianDomingo
added a commit
that referenced
this pull request
Aug 28, 2024
…pdates (#7217) Resolves the issues reported by #7213, which correctly fixes #7156. The latest comment #7156 (comment) goes further into detail on the problems of the initial PR.
JulianDomingo
pushed a commit
to JulianDomingo/shaka-player
that referenced
this pull request
Aug 28, 2024
…ka-project#7213) Reverts shaka-project#7157 ("fix: Defer `closeSegmentIndex()` for old streams during ABR switches when segment fetches are ongoing") A regression was reported in video-dev.org Slack, and they narrowed it down to this PR. Playing https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/4577dca5f8a44756875ab5cc913cd1f1/index.mpd with this PR, reportedly: > playback stops rendering with a warning "cannot find segment endTime" just a few seconds prior to the rendering alt. This was initially observed on Samsung TVs, but then later on LG and even in Chrome.
JulianDomingo
added a commit
to JulianDomingo/shaka-player
that referenced
this pull request
Aug 28, 2024
…pdates (shaka-project#7217) Resolves the issues reported by shaka-project#7213, which correctly fixes shaka-project#7156. The latest comment shaka-project#7156 (comment) goes further into detail on the problems of the initial PR.
avelad
pushed a commit
that referenced
this pull request
Aug 29, 2024
…pdates (#7217) Resolves the issues reported by #7213, which correctly fixes #7156. The latest comment #7156 (comment) goes further into detail on the problems of the initial PR.
avelad
pushed a commit
that referenced
this pull request
Aug 29, 2024
…pdates (#7217) Resolves the issues reported by #7213, which correctly fixes #7156. The latest comment #7156 (comment) goes further into detail on the problems of the initial PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7157 ("fix: Defer
closeSegmentIndex()for old streams during ABR switches when segment fetches are ongoing")A regression was reported in video-dev.org Slack, and they narrowed it down to this PR. Playing https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/4577dca5f8a44756875ab5cc913cd1f1/index.mpd with this PR, reportedly:
This was initially observed on Samsung TVs, but then later on LG and even in Chrome.