Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not minify CodecSwitchingStrategy enum keys #7200

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

tykus160
Copy link
Member

Enum keys has been minified in release build.
As comments were using wrong syntax, they weren't displayed in documentation.

@tykus160 tykus160 added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Aug 23, 2024
@tykus160 tykus160 requested a review from avelad August 23, 2024 12:36
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit f718139 into shaka-project:main Aug 23, 2024
16 of 18 checks passed
@tykus160 tykus160 deleted the wt-codec-switching-fix branch August 25, 2024 06:45
avelad pushed a commit that referenced this pull request Aug 26, 2024
Enum keys has been minified in release build.
As comments were using wrong syntax, they weren't displayed in
documentation.
avelad pushed a commit that referenced this pull request Aug 26, 2024
Enum keys has been minified in release build.
As comments were using wrong syntax, they weren't displayed in
documentation.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants