-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DASH): Fix EventStream Elements creation #7194
Conversation
@willdharris can you review it? Thanks! |
Incremental code coverage: 87.50% |
This PR looks beneficial but doesn't resolve the memory issues reported. I will add further detail in #7148. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like this doesn't completely fix the problem, but it at least looks like a good start.
Related to #7148 Does not create parent elements anymore to reduce memory consumption. Starts to use `createElementNS()` so created elements will keep proper cases for tag names and they won't be anymore of type `HTMLElement`, but `Element`, which should be more lightweight and suitable for our needs.
Related to #7148 Does not create parent elements anymore to reduce memory consumption. Starts to use `createElementNS()` so created elements will keep proper cases for tag names and they won't be anymore of type `HTMLElement`, but `Element`, which should be more lightweight and suitable for our needs.
Hello @tykus160 [Failed to execute 'createElementNS' on 'Document': The namespace URI provided ('') is not valid for the qualified name provided ('scte35:Signal').] This error occurs when parsing the following EventStream section of my DASH manifest:
|
Related to #7148
Does not create parent elements anymore to reduce memory consumption.
Starts to use
createElementNS()
so created elements will keep proper cases for tag names and they won't be anymore of typeHTMLElement
, butElement
, which should be more lightweight and suitable for our needs.