From 7268a2b64dfe74c9171316e49472b0ad399bc46e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wojciech=20Tyczy=C5=84ski?= Date: Fri, 11 Oct 2024 13:45:34 +0200 Subject: [PATCH] fix(PS4/5): Disable smooth codec switch on PS4/5 (#7413) Recent tests have shown that although `SourceBuffer.changeType()` exists on PS5, calling it when switching between AAC and EC3 always throws an exception. Disable smooth codec switch on that platform together with PS4. --- lib/util/platform.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/util/platform.js b/lib/util/platform.js index bd28fe38f2..0f06c7ec92 100644 --- a/lib/util/platform.js +++ b/lib/util/platform.js @@ -629,7 +629,7 @@ shaka.util.Platform = class { * * Some devices are known not to support `MediaSource.changeType` * well. These devices should use the reload strategy. If a device - * reports that it supports `changeType` but support it reliabley + * reports that it supports `changeType` but support it unreliably * it should be added to this list. * * @return {boolean} @@ -638,7 +638,8 @@ shaka.util.Platform = class { const Platform = shaka.util.Platform; if (Platform.isTizen2() || Platform.isTizen3() || Platform.isTizen4() || Platform.isTizen5() || Platform.isTizen6() || Platform.isWebOS3() || - Platform.isWebOS4() || Platform.isWebOS5()) { + Platform.isWebOS4() || Platform.isWebOS5() || Platform.isPS4() || + Platform.isPS5()) { return false; } // Older chromecasts without GoogleTV seem to not support SMOOTH properly.