Can the Event Listener for 'online' which triggers a reload be configurable?

[g-farrow]

Summary

The behaviour of next-pwa which causes the page to be reloaded when the browser goes back "online" is not always the desired behaviour. When this happens it causes the app to lose its most recent state and interrupts the Users experience.

The code which causes this is here:

next-pwa/register.js

Lines 77 to 79 in e1d3129

	window.addEventListener('online', () => {
	location.reload()
	})

Is there a reason why this code exists (i.e. is it solving another problem)? If it was to be removed/disable would it cause other unexpected behaviour or defects?

Could this behaviour be configurable?

Versions

• next-pwa: 5.2.21
• next: 11.0.0

How To Reproduce

Steps to reproduce the behavior:

1. Go to a next-pwa app
2. Switch the network to "offline" in Dev Tools
3. Switch the network to "online" in Dev Tools
4. See the page reload

Expected Behaviors

Ideally, we can set a new flag in next.config.js e.g.:

module.exports = withPWA({
  pwa: {
    dest: 'public',
    swSrc: '/src/service-worker/index.js',
    cacheOnFrontEndNav: true,
    reloadOnOnline: false
  }
})

Additional Context

If this sounds reasonable, I'm happy to open a PR 👍

[shadowwalker]

Go ahead for the PR

[g-farrow]

Thanks @shadowwalker - I've created PR #236

[devfaic]

@shadowwalker Waiting for the new version with this change included. Thanks @g-farrow for the solution.

[shadowwalker]

Published in 5.2.24