Error when update PAC from Geosite

[samirmhsnv]

Error: The given key was not present in the dictionary

OS: Windows 10 19041.508
Client version: 4.2.1.0
.Net version >= 4.7
VS2015 installed

Error shows that AZ locale is not configured. But the questions is why Client not using fallback locale (EN) ?

2020-10-12 21:54:15.2351|INFO|Shadowsocks.Controller.I18N|Current language is: az-Latn-AZ
2020-10-12 21:54:15.2586|INFO|Shadowsocks.Controller.I18N|Translation for az-Latn-AZ not found
2020-10-12 21:54:15.6200|ERROR|Shadowsocks.Program|System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Shadowsocks.Controller.GeositeUpdater.MergeAndWritePACFile(String group, Boolean blacklist)
   at Shadowsocks.Controller.PACDaemon.TouchPACFile()
   at Shadowsocks.Controller.PACDaemon..ctor(Configuration config)
   at Shadowsocks.Controller.ShadowsocksController.Reload()
   at Shadowsocks.Controller.ShadowsocksController.Start(Boolean regHotkeys)
   at Shadowsocks.Program.Main(String[] args)
2020-10-12 21:59:02.8149|INFO|Shadowsocks.Controller.I18N|Current language is: az-Latn-AZ
2020-10-12 21:59:02.8399|INFO|Shadowsocks.Controller.I18N|Translation for az-Latn-AZ not found
2020-10-12 21:59:03.1659|ERROR|Shadowsocks.Program|System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Shadowsocks.Controller.GeositeUpdater.MergeAndWritePACFile(String group, Boolean blacklist)
   at Shadowsocks.Controller.PACDaemon.TouchPACFile()
   at Shadowsocks.Controller.PACDaemon..ctor(Configuration config)
   at Shadowsocks.Controller.ShadowsocksController.Reload()
   at Shadowsocks.Controller.ShadowsocksController.Start(Boolean regHotkeys)
   at Shadowsocks.Program.Main(String[] args)
2020-10-12 22:03:07.9780|INFO|Shadowsocks.Controller.I18N|Current language is: az-Latn-AZ
2020-10-12 22:03:07.9940|INFO|Shadowsocks.Controller.I18N|Translation for az-Latn-AZ not found

[ghost]

Can you post gui-config.json here with sensitive information masked?

[database64128]

First of all, you have not provided enough information to help diagnose the issue.

Second, I have just finished dozens of tests. The only case where your issue can happen, is when you delete pac.txt and manually change geositeGroup to some invalid group in gui-config.json.

Improvements are coming very soon to prevent the crash and show a message box telling the user they have misconfigured the geosite group. But I wouldn't call it a bug, as it can only happen when the user changes the configuration file without knowing what they have done can lead to undefined behaviors. For now, I'm closing the issue.

[samirmhsnv]

try v4.2.0.1

the same result happens

[samirmhsnv]

First of all, you have not provided enough information to help diagnose the issue.

Second, I have just finished dozens of tests. The only case where your issue can happen, is when you delete pac.txt and manually change geositeGroup to some invalid group in gui-config.json.

Improvements are coming very soon to prevent the crash and show a message box telling the user they have misconfigured the geosite group. But I wouldn't call it a bug, as it can only happen when the user changes the configuration file without knowing what they have done can lead to undefined behaviors. For now, I'm closing the issue.

@database64128 I didn't edit any source file. You can test the bug with this steps:

1. Download version 4.2.1.0 from Releases
2. Use Windows 10 >= v19041.508
3. Change language to Azerbaijan (Latin) on Region Format > Current format

4. Open the Application and that error will happen.

Currently I handled it with changing default locale to English (US) and everything is OK now.

[database64128]

Thanks for the steps! A quick fix is coming.

[database64128]

Please try the latest build artifacts at https://ci.appveyor.com/project/celeron533/shadowsocks-windows/build/job/28i7h5xsmq9gy7pt/artifacts

[samirmhsnv]

@database64128

Just tested and v4.2.0.54 is working as expected 👍🏽