Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pac rule in 4.1.9 is not compatible with old ones #2761

Closed
imba-tjd opened this issue Jan 8, 2020 · 5 comments
Closed

The pac rule in 4.1.9 is not compatible with old ones #2761

imba-tjd opened this issue Jan 8, 2020 · 5 comments

Comments

@imba-tjd
Copy link
Contributor

imba-tjd commented Jan 8, 2020

4.1.9:

var __PROXY__ = '127.0.0.1:1080'
var proxy = __PROXY__;

While the old version is:

var proxy = '__PROXY__';

This change will cause all of the old pac.txt broken 😕. I personally don't think it's appropriate. At least a breaking change notice should be announced.

@chenshaoju
Copy link
Collaborator

Maybe is this change:
ad36bf6

@ghost
Copy link

ghost commented Jan 8, 2020

Maybe is this change:
ad36bf6

Yes, my mistake, haven't tested with custom PAC. It's impratical to roll back, so we need document this now.

For breaking change notification see #2758.

We need design and document PAC rule API, see #2746

(考虑AFK一阵子,最近代码质量不行)

@ghost
Copy link

ghost commented Jan 8, 2020

Another reason is resource management, every resource file has two copy: exe builtin one, and one in file system. I'm planning remove builtin one to simplify this problem, but the project only in my fork now, not sure it's a good idea.

https://github.com/studentmain/shadowsocks-windows/tree/no-builtin-blob

@ghost ghost mentioned this issue Jan 10, 2020
@shuhun
Copy link

shuhun commented Jan 10, 2020

改好就能用了3Q

@imba-tjd
Copy link
Contributor Author

Close as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants