Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is a bug at line 275 in the plugin.c? #2599

Closed
larry19840909 opened this issue Jan 19, 2020 · 1 comment
Closed

Is a bug at line 275 in the plugin.c? #2599

larry19840909 opened this issue Jan 19, 2020 · 1 comment
Labels

Comments

@larry19840909
Copy link

larry19840909 commented Jan 19, 2020

Is a bug at line 275 in the plugin.c?

getcwd() will return NULL when it fails, and will not go to the code block in {} when it succeeds.

I did not understand the logical meaning here, but intuitively it should be wrong writing.

@madeye madeye closed this as completed in d31fba3 Jan 19, 2020
@madeye
Copy link

madeye commented Jan 19, 2020

Thanks, this part of code is kind of dead as very few platform doesn't have get_current_dir_name.

@madeye madeye added the bug label Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants