Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected shift in binding sets when using push constants. #5865

Closed
kaizhangNV opened this issue Dec 13, 2024 · 0 comments · Fixed by #5887
Closed

Unexpected shift in binding sets when using push constants. #5865

kaizhangNV opened this issue Dec 13, 2024 · 0 comments · Fixed by #5887
Assignees
@csyonghe
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Milestone
Q4 2024 (Fall)

Comments

@kaizhangNV
Copy link
Contributor

Unexpected shift in binding sets when using push constants.

Here's a small shader demonstrating this in the playground.

Note the OpDecorate %gData_data DescriptorSet 1.
It'ssupposed to be 0. Removing the uniform uint a from the function signature, i.e. the push constants, results in the expected OpDecorate %gData_data DescriptorSet 0.

relevant issue:
#5595
@csyonghe csyonghe mentioned this issue Dec 16, 2024
Merged
@csyonghe csyonghe self-assigned this Dec 17, 2024
@csyonghe csyonghe added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csyonghe csyonghe

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
Q4 2024 (Fall)
Development

Successfully merging a pull request may close this issue.

Add verification logic on push and specialization constants. csyonghe/slang
2 participants
@csyonghe @kaizhangNV