-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WGSL: Add support for all intrinsics #5053
Comments
You can search for "metal" in hlsl.meta.slang and core.meta.slang and make sure there is a "wgsl" case. |
Thanks Yong, I'll make a list and split it tomorrow. |
@csyonghe I see about 20k lines that contain "metal" in hlsl.meta.slang. I'm not about to paste 10k entries here just so we can have something to point at when splitting this task. @jkwak-work If you feel like you want to split this one, I guess you can split it into chunks
|
I doubt there are 20k of them. You are probably looking at HLSL.meta.slang.h which is the expanded version of it that contains one line for every combination of different texture type parameterization. Actual changes won't be that many. |
We added all metal intrinsics over the course of 2 weeks. |
The spec document lists all built-in functions for WGSL.
|
@jkwak-work Shouldn't we mainly be looking at the list of intrinsics that Slang needs to support? I think we just need to visit all of the places in hlsl.meta.slang and plug in the corresponding WGSL intrinsics (if any) where we can. In places we can't I suppose it gets a little trickier. |
I assume that there will be many functions that WGSL don't have. As an example, hlsl has a function called "sincos" and WGSL don't have anything directly same one.
I think it will be easier if we go down a list by what WGSL has rather than what Slang needs. |
I have a PR that covers "numeric" part of WGSL functions. |
Splitting into subtasks based on this list: |
The text was updated successfully, but these errors were encountered: