Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan barriers needs to be queued outside a renderpass. #118

Open
csyonghe opened this issue Dec 19, 2024 · 0 comments
Open

Vulkan barriers needs to be queued outside a renderpass. #118

csyonghe opened this issue Dec 19, 2024 · 0 comments

Comments

@csyonghe
Copy link
Contributor

Currently barriers are queued during processing of CommandID::SetRayTracingState, which is too late because we are already inside a renderpass. Vulkan validation layer complains about barriers between BeginRenderPass and EndRenderPass.

We should do a dry pass over all commands between a render pass, and queue all the barriers before we call vkCmdBeginRenderPass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csyonghe