Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pronunciation + pronunciation info field to settings/layout for presenter of desktop #210

Open
bhajneet opened this issue Oct 10, 2019 · 4 comments
Labels
□ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

@sarabveer how should these two fields be displayed? Can they be combined into one toggle/field? Will there be multiple sources of these or will multiple schools of thought be added to same field (latter preferable imo)?

Originally posted by @bhajneet in shabados/database#1236 (comment)

@bhajneet bhajneet added Status: Confirmed □ Type Story Feature or requirement written from the user's perspective using non-technical language. labels Oct 10, 2019
@bhajneet
Copy link
Member Author

@Harjot1Singh please provide time estimate to add these two db fields as one single field + toggle in presenter. I can do the CSS portion, but it should basically match punjabi and go between gurbani + english translation.

@sarabveer
Copy link

Will there be multiple sources of these or will multiple schools of thought be added to same field (latter preferable imo)?

There will be multiple sources. This pronunciation alongside pronunciation_info will be merged in with the footnotes column. shabados/database#375

@Harjot1Singh
Copy link
Member

@bhajneet adding it in should take a couple of hours, the blocker here is DB-related afaik (do we it in a display-ready format etc and what changes to DB are required etc)

@bhajneet
Copy link
Member Author

Note I'd rather move english, hindi, urdu transliteration also into the "pronunciation" section. So some of them will be dynamically generated via gurmukhi-utils and others are in the db. Not sure if you want to consolodiate the backend or just group them together in a "pronunciation section" of the frontend/settings

_Related #186 _

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
□ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
Status: Triage
Development

No branches or pull requests

3 participants