Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Travis stages to run JS tests separately #1116

Merged
merged 1 commit into from
May 6, 2018

Conversation

ArthurHoaro
Copy link
Member

Related to this comment.

I chose to use stages here instead of matrix because, in my understanding, using matrix would require a bunch of if in the script section.

The only downside I see here is that the JS tests don't run in parallel, they wait for the test stage to be successfully completed.

@ArthurHoaro ArthurHoaro added tools developer tools in review 3rd party interoperability with third-party platforms labels Mar 31, 2018
@ArthurHoaro ArthurHoaro added this to the 0.10.0 milestone Mar 31, 2018
@ArthurHoaro ArthurHoaro self-assigned this Mar 31, 2018
@ArthurHoaro ArthurHoaro requested a review from virtualtam March 31, 2018 11:54
@virtualtam
Copy link
Member

Interesting resources for configuring Travis CI with projects/repositories using multiple programming languages:

I didn't know the build matrix could be used in such a way... let me know if I should take a look at this to propose a future PR :)

@ArthurHoaro ArthurHoaro force-pushed the ci/eslint branch 2 times, most recently from 0889880 to 3a737e2 Compare May 5, 2018 12:11
@ArthurHoaro
Copy link
Member Author

Thank you for you resources. It works surprisingly well because the directives inside the matrix (:neo:) seems to override the global ones.

@virtualtam
Copy link
Member

I know Continuous Integration

@ArthurHoaro ArthurHoaro merged commit 73c5af5 into shaarli:master May 6, 2018
@ArthurHoaro ArthurHoaro deleted the ci/eslint branch May 6, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party interoperability with third-party platforms in review tools developer tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants