Docker: build frontend dependencies with node and yarn #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHoaro
force-pushed
the
docker/node-yarn-webpack
branch
from
86bc344 to
a9bad6e
Compare
virtualtam
reviewed
Mar 26, 2018
docker/alpine/Dockerfile.master
Outdated
| @@ -8,6 +8,16 @@ RUN curl -L https://github.com/shaarli/Shaarli/archive/master.tar.gz | tar xzf - | |||
| && composer --prefer-dist --no-dev install | |||
|
|
|||
| # Stage 2: | |||
| # - Frontend dependencies | |||
| FROM node:latest as node | |||
| RUN echo `pwd` | |||
docker/alpine/Dockerfile.master
Outdated
| @@ -8,6 +8,16 @@ RUN curl -L https://github.com/shaarli/Shaarli/archive/master.tar.gz | tar xzf - | |||
| && composer --prefer-dist --no-dev install | |||
|
|
|||
| # Stage 2: | |||
| # - Frontend dependencies | |||
| FROM node:latest as node | |||
There was a problem hiding this comment.
suggestions:
- use an Alpine-based image for size & speed
- pin the major (and maybe minor?) NodeJS version
e.g. FROM node:9.9-alpine
There was a problem hiding this comment.
Hm, good idea, the size ratio is 1/10:
node 9.9-alpine 3e60aa6db49b 5 days ago 68.4MB
node latest 4885ab8871c2 5 days ago 673MB
a9bad6e to
94abe0a
Compare
virtualtam
approved these changes
Mar 27, 2018
There was a problem hiding this comment.
Builds and runs fine!
There's a Node warning that can be easily fixed:
yarn install v1.5.1
warning package.json: No license field
warning No license field
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 22.29s.
yarn run v1.5.1
warning package.json: No license field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1072 - please only check the latest commit.
Tested locally, it seems to work fine.
Currently, it can be tested by replacing the code retrieval with: