diff --git a/worlds/aquaria/Locations.py b/worlds/aquaria/Locations.py index 7360efde065e..33d165db411a 100644 --- a/worlds/aquaria/Locations.py +++ b/worlds/aquaria/Locations.py @@ -185,7 +185,7 @@ class AquariaLocations: "Mithalas City, second bulb at the end of the top path": 698040, "Mithalas City, bulb in the top path": 698036, "Mithalas City, Mithalas Pot": 698174, - "Mithalas City, urn in the Cathedral flower tube entrance": 698128, + "Mithalas City, urn in the Castle flower tube entrance": 698128, } locations_mithalas_city_fishpass = { @@ -246,7 +246,7 @@ class AquariaLocations: "Kelp Forest top left area, bulb in the bottom left clearing": 698044, "Kelp Forest top left area, bulb in the path down from the top left clearing": 698045, "Kelp Forest top left area, bulb in the top left clearing": 698046, - "Kelp Forest top left, Jelly Egg": 698185, + "Kelp Forest top left area, Jelly Egg": 698185, } locations_forest_tl_fp = { @@ -332,7 +332,7 @@ class AquariaLocations: } locations_veil_tr_l = { - "The Veil top right area, bulb in the top of the waterfall": 698080, + "The Veil top right area, bulb at the top of the waterfall": 698080, "The Veil top right area, Transturtle": 698210, } diff --git a/worlds/aquaria/Regions.py b/worlds/aquaria/Regions.py index f2f85749f3fb..28120259254c 100755 --- a/worlds/aquaria/Regions.py +++ b/worlds/aquaria/Regions.py @@ -771,6 +771,7 @@ def __connect_sunken_city_regions(self) -> None: self.__connect_regions("Sunken City left area", "Sunken City boss area", self.sunken_city_l, self.sunken_city_boss, lambda state: _has_beast_form(state, self.player) and + _has_sun_form(state, self.player) and _has_energy_form(state, self.player) and _has_bind_song(state, self.player)) @@ -983,7 +984,7 @@ def __adjusting_urns_rules(self) -> None: lambda state: _has_damaging_item(state, self.player)) add_rule(self.multiworld.get_location("Mithalas City, third urn in the city reserve", self.player), lambda state: _has_damaging_item(state, self.player)) - add_rule(self.multiworld.get_location("Mithalas City, urn in the Cathedral flower tube entrance", self.player), + add_rule(self.multiworld.get_location("Mithalas City, urn in the Castle flower tube entrance", self.player), lambda state: _has_damaging_item(state, self.player)) add_rule(self.multiworld.get_location("Mithalas City Castle, urn in the bedroom", self.player), lambda state: _has_damaging_item(state, self.player)) @@ -1023,7 +1024,7 @@ def __adjusting_soup_rules(self) -> None: lambda state: _has_hot_soup(state, self.player) and _has_beast_form(state, self.player)) add_rule(self.multiworld.get_location("Sun Worm path, second cliff bulb", self.player), lambda state: _has_hot_soup(state, self.player) and _has_beast_form(state, self.player)) - add_rule(self.multiworld.get_location("The Veil top right area, bulb in the top of the waterfall", self.player), + add_rule(self.multiworld.get_location("The Veil top right area, bulb at the top of the waterfall", self.player), lambda state: _has_hot_soup(state, self.player) and _has_beast_form(state, self.player)) def __adjusting_under_rock_location(self) -> None: @@ -1175,7 +1176,7 @@ def __no_progression_hard_or_hidden_location(self) -> None: self.multiworld.get_location("Sun Worm path, second cliff bulb", self.player).item_rule =\ lambda item: item.classification != ItemClassification.progression - self.multiworld.get_location("The Veil top right area, bulb in the top of the waterfall", + self.multiworld.get_location("The Veil top right area, bulb at the top of the waterfall", self.player).item_rule =\ lambda item: item.classification != ItemClassification.progression self.multiworld.get_location("Bubble Cave, bulb in the left cave wall", diff --git a/worlds/aquaria/__init__.py b/worlds/aquaria/__init__.py index 3c0cc3bdedca..ce46aeea75aa 100644 --- a/worlds/aquaria/__init__.py +++ b/worlds/aquaria/__init__.py @@ -167,14 +167,10 @@ def create_items(self) -> None: self.__pre_fill_item("Transturtle Simon Says", "Arnassi Ruins, Transturtle", precollected) self.__pre_fill_item("Transturtle Arnassi Ruins", "Simon Says area, Transturtle", precollected) for name, data in item_table.items(): - if name in precollected: - precollected.remove(name) - self.multiworld.itempool.append(self.create_item(self.get_filler_item_name())) - else: - if name not in self.exclude: - for i in range(data.count): - item = self.create_item(name) - self.multiworld.itempool.append(item) + if name not in self.exclude: + for i in range(data.count): + item = self.create_item(name) + self.multiworld.itempool.append(item) def set_rules(self) -> None: """ diff --git a/worlds/aquaria/test/__init__.py b/worlds/aquaria/test/__init__.py index 198ccb0f628b..5c63c9bb2968 100644 --- a/worlds/aquaria/test/__init__.py +++ b/worlds/aquaria/test/__init__.py @@ -56,7 +56,7 @@ "Mithalas City, second bulb at the end of the top path", "Mithalas City, bulb in the top path", "Mithalas City, Mithalas Pot", - "Mithalas City, urn in the Cathedral flower tube entrance", + "Mithalas City, urn in the Castle flower tube entrance", "Mithalas City, Doll", "Mithalas City, urn inside a home fish pass", "Mithalas City Castle, bulb in the flesh hole", @@ -93,7 +93,7 @@ "Kelp Forest top left area, bulb in the bottom left clearing", "Kelp Forest top left area, bulb in the path down from the top left clearing", "Kelp Forest top left area, bulb in the top left clearing", - "Kelp Forest top left, Jelly Egg", + "Kelp Forest top left area, Jelly Egg", "Kelp Forest top left area, bulb close to the Verse Egg", "Kelp Forest top left area, Verse Egg", "Kelp Forest top right area, bulb under the rock in the right path", @@ -125,7 +125,7 @@ "Turtle cave, Urchin Costume", "The Veil top right area, bulb in the middle of the wall jump cliff", "The Veil top right area, Golden Starfish", - "The Veil top right area, bulb in the top of the waterfall", + "The Veil top right area, bulb at the top of the waterfall", "The Veil top right area, Transturtle", "The Veil bottom area, bulb in the left path", "The Veil bottom area, bulb in the spirit path", diff --git a/worlds/aquaria/test/test_beast_form_access.py b/worlds/aquaria/test/test_beast_form_access.py index c25070d470b5..4bb4d5656c01 100644 --- a/worlds/aquaria/test/test_beast_form_access.py +++ b/worlds/aquaria/test/test_beast_form_access.py @@ -20,14 +20,14 @@ def test_beast_form_location(self) -> None: "Mithalas City, second bulb at the end of the top path", "Mithalas City, bulb in the top path", "Mithalas City, Mithalas Pot", - "Mithalas City, urn in the Cathedral flower tube entrance", + "Mithalas City, urn in the Castle flower tube entrance", "Mermog cave, Piranha Egg", "Mithalas Cathedral, Mithalan Dress", "Turtle cave, bulb in Bubble Cliff", "Turtle cave, Urchin Costume", "Sun Worm path, first cliff bulb", "Sun Worm path, second cliff bulb", - "The Veil top right area, bulb in the top of the waterfall", + "The Veil top right area, bulb at the top of the waterfall", "Bubble Cave, bulb in the left cave wall", "Bubble Cave, bulb in the right cave wall (behind the ice crystal)", "Bubble Cave, Verse Egg", diff --git a/worlds/aquaria/test/test_no_progression_hard_hidden_locations.py b/worlds/aquaria/test/test_no_progression_hard_hidden_locations.py index 817b9547a892..b0d2b0d880fa 100644 --- a/worlds/aquaria/test/test_no_progression_hard_hidden_locations.py +++ b/worlds/aquaria/test/test_no_progression_hard_hidden_locations.py @@ -30,7 +30,7 @@ class UNoProgressionHardHiddenTest(AquariaTestBase): "Final Boss area, bulb in the boss third form room", "Sun Worm path, first cliff bulb", "Sun Worm path, second cliff bulb", - "The Veil top right area, bulb in the top of the waterfall", + "The Veil top right area, bulb at the top of the waterfall", "Bubble Cave, bulb in the left cave wall", "Bubble Cave, bulb in the right cave wall (behind the ice crystal)", "Bubble Cave, Verse Egg", diff --git a/worlds/aquaria/test/test_progression_hard_hidden_locations.py b/worlds/aquaria/test/test_progression_hard_hidden_locations.py index 2b7c8ddac93a..390fc40b295d 100644 --- a/worlds/aquaria/test/test_progression_hard_hidden_locations.py +++ b/worlds/aquaria/test/test_progression_hard_hidden_locations.py @@ -30,7 +30,7 @@ class UNoProgressionHardHiddenTest(AquariaTestBase): "Final Boss area, bulb in the boss third form room", "Sun Worm path, first cliff bulb", "Sun Worm path, second cliff bulb", - "The Veil top right area, bulb in the top of the waterfall", + "The Veil top right area, bulb at the top of the waterfall", "Bubble Cave, bulb in the left cave wall", "Bubble Cave, bulb in the right cave wall (behind the ice crystal)", "Bubble Cave, Verse Egg", diff --git a/worlds/aquaria/test/test_sun_form_access.py b/worlds/aquaria/test/test_sun_form_access.py index dfd732ec910c..cbe8c08a52a7 100644 --- a/worlds/aquaria/test/test_sun_form_access.py +++ b/worlds/aquaria/test/test_sun_form_access.py @@ -18,6 +18,9 @@ def test_sun_form_location(self) -> None: "Abyss right area, bulb behind the rock in the whale room", "Octopus Cave, Dumbo Egg", "Beating Octopus Prime", + "Sunken City, bulb on top of the boss area", + "Beating the Golem", + "Sunken City cleared", "Final Boss area, bulb in the boss third form room", "Objective complete" ]