Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json field tag <pre> in edit form #2973

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Fix json field tag <pre> in edit form #2973

merged 1 commit into from
Jan 2, 2018

Conversation

lazebny
Copy link
Contributor

@lazebny lazebny commented Dec 30, 2017 •
edited
Loading

Overview

Fixed redundant tag pre in edit form.

lazebny referenced this pull request Dec 30, 2017
@lazebny
Wrap json field in pre block
2381f8e
@arnvald
Copy link
Contributor

arnvald commented Jan 1, 2018

@lazebny thank you for such a quick response and fix! I've just checked this patch in my application and it works fine - the show action displays json wrapped in <pre> tag, but the edit action doesn't add it anymore 👍

@mshibuya mshibuya merged commit 0ad6ce1 into railsadminteam:master Jan 2, 2018
@mshibuya
Copy link
Member

mshibuya commented Jan 2, 2018

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazebny @arnvald @mshibuya