Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add big table limited pagination #2968

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Add big table limited pagination #2968

merged 1 commit into from
Jan 2, 2018

Conversation

lazebny
Copy link
Contributor

@lazebny lazebny commented Dec 10, 2017

Overview

Added limited pagination 'prev', 'next' buttons only. It allows not to do count(*) which is slowly on big tables.

P.S. If this approach is ok we can reuse it in #2808

@lazebny
Copy link
Contributor Author

lazebny commented Dec 12, 2017

@mshibuya could you check it?

@mshibuya
Copy link
Member

Thanks for the PR, I like this feature.

= paginator.render do
%ul.pagination
= prev_page_tag if !current_page.first?
= next_page_tag # if !current_page.last? && !current_page.out_of_range?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented-out code should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will do.

@lazebny
Copy link
Contributor Author

lazebny commented Dec 30, 2017

@mshibuya comments are removed, please let me know if need to fix something else.

@mshibuya mshibuya merged commit e20ff43 into railsadminteam:master Jan 2, 2018
@mshibuya
Copy link
Member

mshibuya commented Jan 2, 2018

Merged in, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants