Toggle checkboxes #2917
Merged
Toggle checkboxes #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bulk_menu deals with selected rows. No checkboxes means no bulk actions. * ensures that export can be used with this configuration
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to toggle the checkboxes on the list section. The bulk menu is also disabled whenever the checkboxes instance variable is set to false on the list section.
The reason for this feature is to remove some of the clutter on the list page if no bulk actions are being used. Some of our clients have said it's distracting without bulk actions being available.
All tests are passing on CentOS 7 with Ruby 2.3.3. Code coverage has increased.