Add SVG file extension to the image detection method #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test needed! |
|
@mshibuya test not really needed, this is just a smart default to show or hide image in the show/list views. Since all browsers can show it, it's good enough I think. When RailsAdmin was created, SVG wasn't really a thing yet 👴 |
bbenezech
added a commit
that referenced
this pull request
Feb 4, 2016
…ct_svg Add SVG file extension to the image detection method
|
Thanks for the merge @bbenezech. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect SVG file uploads as images and present them properly on the interface.