Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: novalidate attribute merging #2373

Merged
merged 1 commit into from
Aug 10, 2015

Conversation

dalpo
Copy link
Contributor

@dalpo dalpo commented Aug 6, 2015

The novalidate actually is overrided by html rails_admin_form_for options in the rails_admin views.
With this PR the novalidate attribute will be merged into the html options correctly.

@dalpo dalpo force-pushed the fix/browser_validations branch from 700f7ca to 21660c1 Compare August 6, 2015 21:52
@dalpo dalpo changed the title Fix: novalidate attribute assignation Fix: novalidate attribute merging Aug 7, 2015
@tagliala
Copy link
Contributor

Please merge this one, I need to disable this feature

Browser validations break the save feature on persisted objets with image attachments

screen shot 2015-08-10 at 13 57 51

mshibuya added a commit that referenced this pull request Aug 10, 2015
@mshibuya mshibuya merged commit 4ee05f1 into railsadminteam:master Aug 10, 2015
@mshibuya
Copy link
Member

Thanks for the fix!

@tagliala
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants