Fix Auto Scroll on expand #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… route to fix back-button woes coming from school page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomhickey
changed the title
mattgianni
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226 by using preferred DOM scrollIntoView instead of fixed-height scrolling. We also watch for the css animation to complete before auto scrolling, this is what really fixes this issue. NOTE: there is a delay because we have to expand first, then auto-scroll, but this is only really noticeable when scrolled to the bottom of the list and clicking on the last school.
Also adds 'id' to the School type so that we aren't using school name in react components.
Also a little bit of code cleanup.