Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subdataset dataset DOI/url to subdatasets view #22

Closed
jsheunis opened this issue Jun 21, 2023 · 7 comments · Fixed by #100
Closed

Add subdataset dataset DOI/url to subdatasets view #22

jsheunis opened this issue Jun 21, 2023 · 7 comments · Fixed by #100

Comments

@jsheunis
Copy link
Collaborator

As displayed currently on the "Publications" view.

@jsheunis
Copy link
Collaborator Author

IIRC only the catalog's javascript code needs to be updated for this change, i.e. nothing would be needed re catalog entry generation/update.

@jsheunis
Copy link
Collaborator Author

jsheunis commented Oct 6, 2023

Ok, it was both JS and html, but not a major change... Here's a sample:

Screenshot 2023-10-06 at 15 36 12

@jsheunis
Copy link
Collaborator Author

jsheunis commented Oct 6, 2023

One thing to know about the decision to go with https://shields.io/ is that the current link references the online badge images, i.e. connectivity is needed.

@mslw
Copy link
Collaborator

mslw commented Oct 6, 2023

Personally i'm OK with connectivity, can't remember ever viewing the catalog offline.

Also personally, I think it a badge feels a bit heavy, visually. Curious to get other opinions.

@jsheunis
Copy link
Collaborator Author

jsheunis commented Oct 6, 2023

Here's an example with URL also shown. the url property on a dataset is an array, since there could be multiple URLs. At the moment I'm arbitrarily displaying the last element in the array. Also, I'm not displaying it in the same way as the two-part DOI | some/doi, because a dataset URL might be quite long, and that is visually not great.

Screenshot 2023-10-06 at 15 56 07

@mslw
Copy link
Collaborator

mslw commented Oct 9, 2023

Going back to this issue and taking a fresh look, I think I'm leaning (slightly) towards having the DOI badge and no URL badge.

At first I thought that showing the DOI like all other fields are shown (version, modified) would make most sense, and a badge looks a bit off compared to all other elements. But now I think that a doi badge looks like a "distinction" awarded to the dataset, which is probably a positive thing to do in recognition of good practice. Having a URL is less of a distinction, and the badge (short or long) looks more off than the doi badge.

@mslw
Copy link
Collaborator

mslw commented May 15, 2024

Note: one way to display badges without relying on external services could be to have two divs (one containing word "DOI" and the other containing doi itself) styled with color and border-*-radius, possibly in another div - GIN does that.

And BTW, the JS code powering shields.io, badge-maker is CC0. Badgen, the library powering badgen.net is ISC licensed, and should be lighter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants