Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow customization of special schemes #763

Open
1 task done
lufte opened this issue Apr 8, 2022 · 3 comments
Open
1 task done

[Feature] Allow customization of special schemes #763

lufte opened this issue Apr 8, 2022 · 3 comments

Comments

@lufte
Copy link

lufte commented Apr 8, 2022

  • Note that this crate implements the URL Standard not RFC 1738 or RFC 3986

I would like to work with some non-special schemes (gemini, gopher...) but get the same behaviour as if they were special, like IPv4 hosts and no empty hosts. I understand it's not standard, but it would be useful in many cases. A compile-time setting wouldn't even require any change to the API.

Would this be considered? I am willing to create a PR if needed.

@annevk
Copy link

annevk commented Feb 6, 2023

I think a better solution would to write a wrapper URLProcessor crate of sorts that does this. We shouldn't tweak how URLs are parsed.

@tmccombs
Copy link
Contributor

tmccombs commented Feb 6, 2023

How would that work? The current API doesn't really provide a good way to create such a wrapper.

@annevk
Copy link

annevk commented Feb 6, 2023

Sorry, I didn't mean a literal wrapper. Just a conceptual function that takes a URL and returns a "ProcessedURL".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants