url 1.7.2 and url 2.0.0 disagree whether - is a valid host, intentional?

[jplatte]

Some tests in ruma-identifiers that used - as an invalid host name broke when upgrade url from 1.7.2 to 2.0.0. Is - intended to be allowed as a hostname?

[valenting]

new URL("http://-/") works in both Firefox and Chrome.

[SimonSapin]

This sounds related to #484. @nox, is it possible that he behavior changed even with check_hyphens: false?

[nox]

AFAIK no, my PR just relaxed some validation errors, it did not add any error case to the best of my knowledge.

[jplatte]

Should I bisect which commit changed this behaviour?

[jplatte]

did not add any error case

Well url 2.x errors in fewer cases than 1.x. Maybe it was a bug that this wasn't accepted in 1.x?

[lucacasonato]

Let's close this, as http://-/ is a valid URL as per spec. See https://jsdom.github.io/whatwg-url/#url=aHR0cDovLy0v&base=YWJvdXQ6Ymxhbms=